Skip to content

typo: FILED_ID_PROP -> FIELD_ID_PROP #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

kevinjqliu
Copy link
Contributor

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

LLMs are great at catching typos. Found this while reviewing #1482

This change is safe since FILED_ID_PROP is not public and not exported

Are these changes tested?

@kevinjqliu kevinjqliu marked this pull request as ready for review July 8, 2025 15:56
@kevinjqliu kevinjqliu requested a review from liurenjie1024 July 8, 2025 15:56
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this fix!

@liurenjie1024 liurenjie1024 merged commit 3fa9027 into apache:main Jul 8, 2025
17 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/typo branch July 8, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants